[Re: [PATCH] serial: rda-uart: make it explicitly non-modular] On 22/04/2019 (Mon 23:13) Greg Kroah-Hartman wrote:
> On Mon, Apr 22, 2019 at 03:06:57AM -0400, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> >
> > drivers/tty/serial/Kconfig:config SERIAL_RDA
> > drivers/tty/serial/Kconfig: bool "RDA Micro serial port support"
> >
> > ...meaning that it currently is not being built as a module by anyone.
> >
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> >
> > We explicitly disallow a driver unbind, since that doesn't have a
> > sensible use case anyway, and it allows us to drop the ".remove"
> > code for non-modular drivers.
> >
> > Since module_init translates to device_initcall in the non-modular
> > case, the init ordering remains unchanged with this commit.
> >
> > We also delete the MODULE_LICENSE tag etc. since all that information
> > is already contained at the top of the file in the comments.
> >
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Jiri Slaby <jslaby@xxxxxxxx>
> > Cc: linux-serial@xxxxxxxxxxxxxxx
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> >
> > diff --git a/drivers/tty/serial/rda-uart.c b/drivers/tty/serial/rda-uart.c
> > index 284623eefaeb..ce3d9c6fcb91 100644
> > --- a/drivers/tty/serial/rda-uart.c
> > +++ b/drivers/tty/serial/rda-uart.c
> > @@ -4,14 +4,15 @@
> > *
> > * Copyright RDA Microelectronics Company Limited
> > * Copyright (c) 2017 Andreas Färber
> > - * Copyright (c) 2018 Manivannan Sadhasivam
> > + * Copyright (c) 2018 Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > + * License: GPL
>
> That "License" line means nothing. Please stick to a proper SPDX
> license tag, don't make things confusing (hint, what you wrote here
> could imply GPLv1, and I don't think you meant that...")
Actually, no. I did mean that, as it was a 1:1 direct transformation of
what the author had put in for MODULE_LICENSE -- as you can see in the
part of the patch that you trimmed from the reply:
-MODULE_AUTHOR("Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>");
-MODULE_DESCRIPTION("RDA8810PL serial device driver");
-MODULE_LICENSE("GPL");
...and I felt it wasn't my place to silently "upgrade" the license that
the original author chose, as I don't want to get into license debates.
It doesn't matter in this case, since the author wants to convert it to
tristate. But for future reference, if I see MODULE_LICENSE("GPL") and
that differs from the robot inserted SPDX line which perhaps says GPLv2,
what is the right course of action? Ignore the MODULE_LICENSE content
as long as there is an SPDX line, regardless of what it says?
Paul.
--
>
> thanks,
>
> greg k-h
