On Tue, Apr 02, 2019 at 08:20:19PM -0700, jay.dolan@xxxxxxxxxxx wrote: > --- a/include/uapi/linux/serial_reg.h > +++ b/include/uapi/linux/serial_reg.h > @@ -3,10 +3,10 @@ > * include/linux/serial_reg.h > * > * Copyright (C) 1992, 1994 by Theodore Ts'o. > - * > - * Redistribution of this file is permitted under the terms of the GNU > + * > + * Redistribution of this file is permitted under the terms of the GNU > * Public License (GPL) > - * > + * > * These are the UART port assignments, expressed as offsets from the base > * register. These assignments should hold for any serial port based on > * a 8250, 16450, or 16550(A). > @@ -97,7 +97,7 @@ > > #define UART_LCR 3 /* Out: Line Control Register */ > /* > - * Note: if the word length is 5 bits (UART_LCR_WLEN5), then setting > + * Note: if the word length is 5 bits (UART_LCR_WLEN5), then setting > * UART_LCR_STOP will select 1.5 stop bits, not 2 stop bits. > */ > #define UART_LCR_DLAB 0x80 /* Divisor latch access bit */ Why did you make the above changes to the file? That has nothing to do with your change. > @@ -376,5 +376,10 @@ > #define UART_ALTR_EN_TXFIFO_LW 0x01 /* Enable the TX FIFO Low Watermark */ > #define UART_ALTR_TX_LOW 0x41 /* Tx FIFO Low Watermark */ > > +/* > + * Definition for Pericom sample clock register > + */ > +#define UART_PCM_SCR 0x02 /*Sample Clock Register*/ You need extra ' ' for your comment. And why is this a new api you are needing to create? Are you sure about this? thanks, greg k-h