Hi Aditya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on v5.1-rc2 next-20190325] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Aditya-Pakki/tty-8250-fix-a-missing-check-for-pci_ioremap_bar/20190325-151723 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: i386-randconfig-a2-201912 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/tty/serial/8250/8250_lpss.c: In function 'qrk_serial_exit_dma': drivers/tty/serial/8250/8250_lpss.c:207:45: error: invalid type argument of '->' (have 'struct dw_dma_chip') pci_iounmap(param->dma_dev, &lpss->dma_chip->regs); ^ >> drivers/tty/serial/8250/8250_lpss.c:207:14: warning: passing argument 1 of 'pci_iounmap' from incompatible pointer type pci_iounmap(param->dma_dev, &lpss->dma_chip->regs); ^ In file included from arch/x86/include/asm/io.h:232:0, from arch/x86/include/asm/realmode.h:15, from arch/x86/include/asm/acpi.h:33, from arch/x86/include/asm/fixmap.h:29, from arch/x86/include/asm/apic.h:10, from arch/x86/include/asm/smp.h:13, from include/linux/smp.h:68, from include/linux/topology.h:33, from include/linux/gfp.h:9, from include/linux/umh.h:4, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/tty/serial/8250/8250_lpss.c:10: include/asm-generic/iomap.h:107:13: note: expected 'struct pci_dev *' but argument is of type 'struct device *' extern void pci_iounmap(struct pci_dev *dev, void __iomem *); ^ vim +/pci_iounmap +207 drivers/tty/serial/8250/8250_lpss.c 197 198 static void qrk_serial_exit_dma(struct lpss8250 *lpss) 199 { 200 struct dw_dma_slave *param = &lpss->dma_param; 201 202 if (!param->dma_dev) 203 return; 204 205 dw_dma_remove(&lpss->dma_chip); 206 > 207 pci_iounmap(param->dma_dev, &lpss->dma_chip->regs); 208 } 209 #else /* CONFIG_SERIAL_8250_DMA */ 210 static void qrk_serial_setup_dma(struct lpss8250 *lpss, struct uart_port *port) {} 211 static void qrk_serial_exit_dma(struct lpss8250 *lpss) {} 212 #endif /* !CONFIG_SERIAL_8250_DMA */ 213 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
