On Fri, Mar 8, 2019 at 10:38 AM Nathan Chancellor <natechancellor@xxxxxxxxx> wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' > is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > It's not wrong; when options is NULL, baud has no default value. Use > 9600 as that is a sane default. > > Link: https://github.com/ClangBuiltLinux/linux/issues/395 > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> Great find. Thanks for the fix, and thanks Greg for the advice and additional analysis here. Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > --- > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 3bcec1c20219..35e5f9c5d5be 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console *co, char *options) > { > struct uart_port *uport; > struct qcom_geni_serial_port *port; > - int baud; > + int baud = 9600; > int bits = 8; > int parity = 'n'; > int flow = 'n'; > -- > 2.21.0 > -- Thanks, ~Nick Desaulniers
