On Jan 10 2019, Anup Patel <anup@xxxxxxxxxxxxxx> wrote: > Instead of doing '\n' handling here, we should do it in BBL or > OpenSBI (i.e. SBI runtime firmware) otherwise all users of > SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD, > FreeRTOS, U-Boot S-mode, etc) will endup having '\n' > handling. I don't think the serial driver should do NLCR handling on its own, without being instructed by the tty layer. Since the earlycon does not have a tty layer, it needs to handle it explicitly. Andreas. -- Andreas Schwab, SUSE Labs, schwab@xxxxxxx GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
