Hi Geert,
On 2019/1/7 23:24, Geert Uytterhoeven wrote:
> Hi Shaokun,
>
> Thanks for your patch!
>
> On Mon, Jan 7, 2019 at 3:58 PM Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx> wrote:
>> In file included from ./include/linux/rwsem.h:16:0,
>> from ./include/linux/notifier.h:15,
>> from ./include/linux/clk.h:17,
>> from drivers/tty/serial/sh-sci.c:24:
>> drivers/tty/serial/sh-sci.c: In function ‘sci_submit_rx’:
>> ./include/linux/spinlock.h:279:3: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>> _raw_spin_unlock_irqrestore(lock, flags); \
>> ^
>> drivers/tty/serial/sh-sci.c:1338:16: note: ‘flags’ was declared here
>> unsigned long flags;
>> GCC version is gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609.
>>
>> Let's fix it initializing the flags to 0.
>
> This is a false positive, so please don't preinitialize flags.
>
Agree,
I just want to eliminate this unfriendly warning.
Thanks,
Shaokun
>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
>
>> ---
>> drivers/tty/serial/sh-sci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
>> index 8df0fd824520..aa5dd9b417f5 100644
>> --- a/drivers/tty/serial/sh-sci.c
>> +++ b/drivers/tty/serial/sh-sci.c
>> @@ -1335,7 +1335,7 @@ static int sci_submit_rx(struct sci_port *s, bool port_lock_held)
>> {
>> struct dma_chan *chan = s->chan_rx;
>> struct uart_port *port = &s->port;
>> - unsigned long flags;
>> + unsigned long flags = 0;
>> int i;
>>
>> for (i = 0; i < 2; i++) {
>
> Gr{oetje,eeting}s,
>
> Geert
>
