Serial device with PCI class memory device (0x05)

[Gerhard Khüny <gerhard.khueny@xxxxxxxxx>]

Hello,

I have a question regarding the function
serial_pci_is_class_communication() in 8250_pci:

static int serial_pci_is_class_communication(struct pci_dev *dev) {

        /*
        * If it is not a communications device or the programming
        * interface is greater than 6, give up.
        */
        if ((((dev->class >> 8) != PCI_CLASS_COMMUNICATION_SERIAL) &&
             ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_MULTISERIAL) &&
             ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_MODEM)) ||
            (dev->class & 0xff) > 6)
               return -ENODEV;

        return 0;

}

We have implemented a serial interface in a FPGA. The existing driver
8250_pci is working perfect for us. Only the check using the function
serial_pci_is_class_communication does not work since the PCI class is
0x05, subclass is 0x00 and programming interface is 0x00 for our
device.
My question is, if it is the intention to exclude PCI class memory
devices implementing a serial driver? The comment in the code could
say something different.

Thanks!
Gerhard