Hi Wolfram,
On Mon, Dec 10, 2018 at 8:00 PM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > if (!port_lock_held)
> > spin_unlock_irqrestore(&port->lock, flags);
> > + return -1;
>
> -Esomething here...
>
> > } else {
> > + if (sci_submit_rx(s, false))
> > + goto handle_pio;
>
> and 'sci_submit_rx() < 0' here? I think it makes it more readable that
> this is an error case then. 'if sci_submit_rx() do_something' sounds a
> bit like the good case if boolean logic was used.
Thanks, will update for v4, using -EAGAIN.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
