Quoting Ryan Case (2018-11-27 18:37:15) > On Tue, Nov 27, 2018 at 6:04 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > Quoting Ryan Case (2018-11-27 17:24:44) > > > > > I hope underflow is impossible as well. However, if the hardware did > > > wind up in a strange state I wanted to err on the side of not throwing > > > away data and being able to resume later if things recovered. I can > > > remove the defensive checks if that's the custom, otherwise I'll > > > update the comparison logic accordingly. > > > > Well it looks like impossible code because an unsigned value can't be > > less than zero. So it's not about customs, more about dead code removal. > > Agreed on the current dead code aspect which is why I offered the > option of updating the comparison logic, but I can just delete it if > you want. Ok, got it.
