On Wed, Nov 14, 2018 at 9:10 AM Johan Hovold <johan@xxxxxxxxxx> wrote: > > Make the synchronous serdev_device_write() helper behave analogous to > the asynchronous serdev_device_write_buf() by returning the number of > bytes written (or rather buffered) also on timeout. > > This will allow drivers to distinguish the case where data was partially > written from the case where no data was written. > > Also update the only two users that checked the return value. > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx> > --- > drivers/gnss/serial.c | 2 +- > drivers/gnss/sirf.c | 2 +- > drivers/tty/serdev/core.c | 12 ++++++++++-- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/gnss/serial.c b/drivers/gnss/serial.c > index 31e891f00175..def64b36d994 100644 > --- a/drivers/gnss/serial.c > +++ b/drivers/gnss/serial.c > @@ -65,7 +65,7 @@ static int gnss_serial_write_raw(struct gnss_device *gdev, > > /* write is only buffered synchronously */ > ret = serdev_device_write(serdev, buf, count, MAX_SCHEDULE_TIMEOUT); > - if (ret < 0) > + if (ret < 0 || ret < count) The 2nd condition covers the 1st condition. Though I guess this will all change anyways when you address the FIXME below. > return ret; > > /* FIXME: determine if interrupted? */
