Re: [PATCH RFC 0/2] next round for an uart led trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marcel,

On Wed, Nov 07, 2018 at 08:32:11AM +0100, Marcel Holtmann wrote:
> > this is the next round of a led trigger for an UART. Instead of adding
> > callbacks to serial_core I took an approach similar to the netdev
> > trigger: A work thread checks the statistics of the device and if
> > something happened since the last round the LED is flashed.
> > 
> > This is an early prototype that has broken locking. Also in the long run
> > I want to add some "filters" to the trigger for example to trigger only
> > on RX or TX.
> > 
> > Do you (also) think this is a better approach then in the former
> > discussions?
> 
> would it be simpler to integrate a LED trigger into serdev instead of
> trying to do it on the UART level. You might not be able to catch all
> UARTs, but for the ones that have a serdev driver running on top of
> it, you would.

I don't see the advantage. The statistics are in the uart_port
structure, so there is no gain. Would it simplify the locking?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux