On Tue, Oct 16, 2018 at 02:47:33AM +0000, Andy Duan wrote:
> Fix the typo: UARTCR1_PE -> UARTCTRL_PE
It seems that the first is for lpuart and the latter for lpuart32. Given
that the register set is different, I wonder if there is a better reason
than "both are called lpuart" for being supported in the same driver.
The only functions they share are:
.type (this is bad IMHO)
.request_port (just a "return 0", can be dropped I think)
.release_port (noop, can also be dropped)
.config_port (inherits from .type being identical -> bad)
.verify_port (nothing lpuart{,32} specific in it)
.flush_buffer (just stopps DMA which happens to use struct lpuart_port)
> There have no function impacted since the macro define value is
> the same.
>
> Cc: Uwe Kleine-K枚nig <u.kleine-koenig@xxxxxxxxxxxxxx>
Wow, that's a creative mistyping of my name that I never saw before.
(If you're interested in the details, I suggest looking at the output of
git log --format=fuller | grep -o 'Kleine-K[^ ]*nig' | sort | uniq -c
:-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
