RE: [PATCH tty/serial 1/1] serial: fsl_lpuart: clear parity enable bit when disable parity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Fabio Estevam <festevam@xxxxxxxxx> Sent: 2018年10月15日 18:50
> To: Andy Duan <fugang.duan@xxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Uwe
> Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>;
> linux-serial@xxxxxxxxxxxxxxx; Lukas Wunner <lukas@xxxxxxxxx>
> Subject: Re: [PATCH tty/serial 1/1] serial: fsl_lpuart: clear parity enable bit
> when disable parity
> 
> Hi Andy,
> 
> On Mon, Oct 15, 2018 at 6:49 AM Andy Duan <fugang.duan@xxxxxxx>
> wrote:
> >
> > From: Fugang Duan <fugang.duan@xxxxxxx>
> >
> > Current driver only enable parity enable bit and never clear it when
> > user set the termios. The fix clear the parity enable bit when PARENB
> > flag is not set in termios->c_cflag.
> >
> > The patch also correct the typo "UARTCR1_PE" to "UARTCTRL_PE"
> although
> > there has no function impacted.
> 
> It would be better if this change was in a separate patch.

Thanks for your comment.
I will separate it into two patch in V2.

Andy




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux