Re: [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Max Filippov <jcmvbkbc@xxxxxxxxx>
Subject: Re: [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h>
From: "H. Peter Anvin" <hpa@xxxxxxxxx>
Date: Thu, 4 Oct 2018 16:08:19 -0700
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, Chris Zankel <chris@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, pombredanne@xxxxxxxx, kstewart@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, Jiri Slaby <jslaby@xxxxxxxx>
In-reply-to: <CAMo8BfJRvmNu=oHb4MaB_M7mdR5dMZRgfHb-Me8En3OoUe5m8g@mail.gmail.com>
References: <20181004222953.2229-1-hpa@zytor.com> <20181004222953.2229-6-hpa@zytor.com> <CAMo8BfJRvmNu=oHb4MaB_M7mdR5dMZRgfHb-Me8En3OoUe5m8g@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 10/04/18 15:35, Max Filippov wrote:
> 
> Looks good. But why not removing the header entirely and adding
> generic-y += termbits.h
> to arch/xtensa/include/uapi/asm/Kbuild?
> 

Good idea.  Should do that for others that also have the same #include.

	-hpa

References:
- [PATCH 0/5] termios: remove arch redundancy in <asm/termbits.h>
  - From: H. Peter Anvin (Intel)
- [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h>
  - From: H. Peter Anvin (Intel)
- Re: [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h>
  - From: Max Filippov

Prev by Date: Re: [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h>
Next by Date: patch "TTY: sn_console: Replace spin_is_locked() with spin_trylock()" added to tty-next
Previous by thread: Re: [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h>
Next by thread: [PATCH 4/5] arch/parisc, termios: use <asm-generic/termios.h>
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]