From: He Zhe <zhe.he@xxxxxxxxxxxxx> pr_* is preferred according to scripts/checkpatch.pl. Cc: jason.wessel@xxxxxxxxxxxxx Cc: gregkh@xxxxxxxxxxxxxxxxxxx Cc: jslaby@xxxxxxxx Signed-off-by: He Zhe <zhe.he@xxxxxxxxxxxxx> Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> --- v2: - Split printk cleanups into a single patch - Add cc to stable@xxxxxxxxxxxxxxx v3: - Add pr_fmt for mod name - Remove cc to stable@xxxxxxxxxxxxxxx v4: - Add cc to maintainers and supporters drivers/tty/serial/kgdboc.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index f4d0ef6..371357d 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -8,6 +8,9 @@ * * 2007-2008 (c) Jason Wessel - Wind River Systems, Inc. */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include <linux/kernel.h> #include <linux/ctype.h> #include <linux/kgdb.h> @@ -131,12 +134,12 @@ static void kgdboc_unregister_kbd(void) static int kgdboc_option_setup(char *opt) { if (!opt) { - pr_err("kgdboc: config string not provided\n"); + pr_err("config string not provided\n"); return -EINVAL; } if (strlen(opt) >= MAX_CONFIG_LEN) { - printk(KERN_ERR "kgdboc: config string too long\n"); + pr_err("config string too long\n"); return -ENOSPC; } strcpy(config, opt); @@ -253,7 +256,7 @@ static int param_set_kgdboc_var(const char *kmessage, int len = strlen(kmessage); if (len >= MAX_CONFIG_LEN) { - printk(KERN_ERR "kgdboc: config string too long\n"); + pr_err("config string too long\n"); return -ENOSPC; } @@ -264,8 +267,7 @@ static int param_set_kgdboc_var(const char *kmessage, } if (kgdb_connected) { - printk(KERN_ERR - "kgdboc: Cannot reconfigure while KGDB is connected.\n"); + pr_err("Cannot reconfigure while KGDB is connected.\n"); return -EBUSY; } -- 2.7.4