From: He Zhe <zhe.he@xxxxxxxxxxxxx> pr_* is preferred according to scripts/checkpatch.pl. Cc: stable@xxxxxxxxxxxxxxx Signed-off-by: He Zhe <zhe.he@xxxxxxxxxxxxx> --- v2: - Split printk cleanups into a single patch - Add cc to stable@xxxxxxxxxxxxxxx drivers/tty/serial/kgdboc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 206f8c2..0003d6c 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -136,7 +136,7 @@ static int kgdboc_option_setup(char *opt) } if (strlen(opt) >= MAX_CONFIG_LEN) { - printk(KERN_ERR "kgdboc: config string too long\n"); + pr_err("kgdboc: config string too long\n"); return -ENOSPC; } strcpy(config, opt); @@ -253,7 +253,7 @@ static int param_set_kgdboc_var(const char *kmessage, int len = strlen(kmessage); if (len >= MAX_CONFIG_LEN) { - printk(KERN_ERR "kgdboc: config string too long\n"); + pr_err("kgdboc: config string too long\n"); return -ENOSPC; } @@ -264,8 +264,7 @@ static int param_set_kgdboc_var(const char *kmessage, } if (kgdb_connected) { - printk(KERN_ERR - "kgdboc: Cannot reconfigure while KGDB is connected.\n"); + pr_err("kgdboc: Cannot reconfigure while KGDB is connected.\n"); return -EBUSY; } -- 2.7.4