RE: [PATCH v2 2/3] serial: sh-sci: Add support for separate TEI+DRI interrupts

[Chris Brandt <Chris.Brandt@xxxxxxxxxxx>]

Hi Geert,

On Thursday, July 26, 2018, Geert Uytterhoeven wrote:
> > +static irqreturn_t sci_br_interrupt(int irq, void *ptr);
> 
> You can avoid the forward declaration by moving the whole function here.

OK.

> > @@ -2809,6 +2845,8 @@ static int sci_init_single(struct platform_device
> *dev,
> >                 sci_port->irqs[1] = sci_port->irqs[0];
> >                 sci_port->irqs[2] = sci_port->irqs[0];
> >                 sci_port->irqs[3] = sci_port->irqs[0];
> > +               sci_port->irqs[4] = sci_port->irqs[0];
> > +               sci_port->irqs[5] = sci_port->irqs[0];
> 
> You may want to start using a loop from 1 to ARRAY_SIZE(sci_port->irqs) -
> 1
> instead.

OK, I'll change it.

Chris

��.n��������+%������w��{.n�����{��ǫ����{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��