Re: [PATCH v2 3/3] serial: sh-sci: Document r7s9210 bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On Wed, Jul 25, 2018 at 4:39 PM Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> Add R7S9210 (RZ/A2) support.
> Also describe interrupts property in more detail.
>
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> ---
> v2:
>  * Add more details to interrupts property
>  * Geert gave a Reviewed-by for V1, but then later said that was a
>    mistake because it was missing the interrupts description, so
>    I didn't include his Reviewed-by yet.

Thanks for the update!

With the below typo fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> @@ -72,7 +73,21 @@ Required properties:
>      family-specific and/or generic versions.
>
>    - reg: Base address and length of the I/O registers used by the UART.
> -  - interrupts: Must contain an interrupt-specifier for the SCIx interrupt.
> +  - interrupts: Must contain one or more interrupt-specifiers for the SCIx.
> +                If a single interrupt is expressed, then all events are
> +                multiplexed into this single interrupt.
> +
> +                If multiple interrupts are provided by the hardware, the order
> +                in which the interrupts are listed must match order below. Note
> +                that some HW interrupt events may be muxed together resulting
> +                in duplicate entires.

entries

> +                The interrupt order is as follows:
> +                  1. Error (ERI)
> +                  2. Receive buffer full (RXI)
> +                  3. Transmit buffer empty (TXI)
> +                  4. Break (BRI)
> +                  5. Data Ready (DRI)
> +                  6. Transmit End (TEI)
>
>    - clocks: Must contain a phandle and clock-specifier pair for each entry
>      in clock-names.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux