On Mon, Jul 23, 2018 at 02:09:46AM +0530, Vabhav wrote: > From: Vabhav Sharma <vabhav.sharma@xxxxxxx> > > Numbering the ttyLPn space should not depend on the generic name > "serial<n>". > > If don't add the alias node like:"serial0 = &lpuart0;", then lpuart > will probe failed: > [ 0.773410] fsl-lpuart 2950000.serial: failed to get alias id, errno -19 > > So remove the alias node dependence, and add the support for allocate the > line port automatically. > > v2: > Incorporated Review comments https://patchwork.kernel.org/patch/9473977/ > > Signed-off-by: Yuan Yao <yao.yuan@xxxxxxx> > Signed-off-by: Vabhav Sharma <vabhav.sharma@xxxxxxx> > --- > drivers/tty/serial/fsl_lpuart.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 51e47a6..00f06eb 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -232,6 +232,8 @@ > /* IMX lpuart has four extra unused regs located at the beginning */ > #define IMX_REG_OFF 0x10 > > +static DEFINE_IDA(fsl_lpuart_ida); You forgot to clean up the memory used by this structure when your module is unloaded. Yeah, it's not obvious, go blame the authors of the ida interface for that mess :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
