Hi Marc On Wed, 2018-07-04 at 08:59 +0100, Marc Zyngier wrote: > On 04/07/18 08:47, Mars Cheng wrote: > > Hi Marc > > > > On Wed, 2018-07-04 at 08:35 +0100, Marc Zyngier wrote: > >> On 04/07/18 02:52, Mars Cheng wrote: > >>> This adds basic chip support for MT6765 SoC. > >>> > >>> Signed-off-by: Mars Cheng <mars.cheng@xxxxxxxxxxxx> > >>> --- > >>> arch/arm64/boot/dts/mediatek/Makefile | 1 + > >>> arch/arm64/boot/dts/mediatek/mt6765-evb.dts | 33 ++++++ > >>> arch/arm64/boot/dts/mediatek/mt6765.dtsi | 155 +++++++++++++++++++++++++++ > >>> 3 files changed, 189 insertions(+) > >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt6765-evb.dts > >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt6765.dtsi > >>> > >> > >> [...] > >> > >>> + > >>> + gic: interrupt-controller@c000000 { > >>> + compatible = "arm,gic-v3"; > >>> + #interrupt-cells = <3>; > >>> + #address-cells = <2>; > >>> + #size-cells = <2>; > >>> + #redistributor-regions = <1>; > >>> + interrupt-parent = <&gic>; > >>> + interrupt-controller; > >>> + reg = <0 0x0c000000 0 0x40000>, // distributor > >>> + <0 0x0c100000 0 0x200000>, // redistributor > >>> + <0 0x0c400000 0 0x40000>; // gicc > >> > >> For the second time: please add *all* the GIC CPU interface regions, > >> described in the Cortex-A53 TRM[1] (GICC, GICH, and GICV). > >> > > > > MT6765 has no GICH/GICV/ITS in mediatek design. Have confirmed with our > > designer. > > The only way *not* to have GICH or GICV is to assert GICCDISABLE on the > CPU, in which case you don't have GICC either, nor any support for the > GICv3 at all. So either the designer is wrong or the documentation is > wrong. Which one is it, do you think? > > As for the ITS, that's a perfectly optional part of the design, and not > part of the CPU. > Clarified with our designer. It is our misunderstanding for TRM. GICV/GICH do exist. Will add them in v4 soon. And fix MT6797 in another patch. Thanks. > > MT6797 had similar question from you. Sorry for not mentioned it first. > > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.infradead.org_pipermail_linux-2Dmediatek_2017-2DFebruary_008074.html&d=DwICaQ&c=X9NHckmGz7LNQmqtvpDCYVnn6eFXNivfZeknqiAo-n0&r=Ph_SbcClVGRWmGxVhfr-5CZF9ffiUOE7TZ47ns4ROh4&m=iACLXUO5vXXZCPSvhbBKZFXy0bXdO8f4kbgy6RLi2QM&s=2N4qyy0aMytzNgObeyU4tvCDREX4U1x4oeNgvZwUxvM&e= > > Well, that's wrong too. > > M. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html