Hi Andy, On Tue, May 29, 2018 at 10:35 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, May 29, 2018 at 4:10 PM, Ricardo Ribalda Delgado > <ricardo.ribalda@xxxxxxxxx> wrote: > > Allow creating and deleting devices via sysfs. Devices created will be > > matched to serdev drivers via modalias (the string provided by the user) > > and deleted via their name. > > + int err; > > + char *nline; > Better to read in reversed order. > > + nline = strchr(buf, '\n'); > > + if (nline) > > + *nline = '\0'; > strim() / strstrip() ? > > + nline = strchr(buf, '\n'); > > + if (nline) > > + *nline = '\0'; > Ditto. > > +static DEVICE_ATTR_IGNORE_LOCKDEP(delete_device, 0200, NULL, > > + delete_device_store); > Perhaps leave it on one line? > -- > With Best Regards, > Andy Shevchenko Thanks for your review. I am working on v2 at https://github.com/ribalda/linux/tree/serdev2 it fixes your comments except the line cut for DEVICE_ATTR, I want also to make checkpatch happy ;) Will send v2 to the list after I got more feedback, you can of course ping me if there is something in my tree that it is not fixed properly. Cheers -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
