On Tue, May 29, 2018 at 4:10 PM, Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote: > Allow creating and deleting devices via sysfs. Devices created will be > matched to serdev drivers via modalias (the string provided by the user) > and deleted via their name. > + int err; > + char *nline; Better to read in reversed order. > + nline = strchr(buf, '\n'); > + if (nline) > + *nline = '\0'; strim() / strstrip() ? > + nline = strchr(buf, '\n'); > + if (nline) > + *nline = '\0'; Ditto. > +static DEVICE_ATTR_IGNORE_LOCKDEP(delete_device, 0200, NULL, > + delete_device_store); Perhaps leave it on one line? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
