Hi Uwe On 2018-01-25 at 14:30:42 +0100, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > Hello, > > v1 of this series consisted only of the third patch in this series. When > I sent it (Message-Id: > 20171218094148.13732-1-u.kleine-koenig@xxxxxxxxxxxxxx) Tobias had doubts > because my patch resulted in an enabled read ready interrupt even though > the irq line should be unused. So I added patch 2 in front which ensures > that irqs are not enabled in this case also in other parts of the driver. > While at it I noticed that only a part of the register accesses used the > port's regshift member to calculate register offset and so fixed that in > another patch before. > > This patch set was tested only on a machine that doesn't make use of the > irq line. For that reception of characters works starting with the final > patch in this series. Thanks for working on this. Unfortunately, I currently don't have access to my hardware for testing with an IRQ line. But I'll do so next week. Judging from the code this should be fine though, so Acked-by: Tobias Klauser <tklauser@xxxxxxxxxx> for the whole patch series. > Uwe Kleine-König (3): > serial: altera: ensure port->regshift is honored consistently > serial: altera: don't enable any irq if the device doesn't feature an > irq > serial: altera: set RRDY flag also without irq > > drivers/tty/serial/altera_uart.c | 58 +++++++++++++++++++++++++--------------- > 1 file changed, 36 insertions(+), 22 deletions(-) > > -- > 2.15.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
