Re: [tty:tty-testing 66/66] include/linux/tty.h:437:1: error: expected identifier or '(' before '{' token

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 22, 2018 at 11:50:28PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head:   fd7ea3a98728a4861c23d2c616649238f15890ff
> commit: fd7ea3a98728a4861c23d2c616649238f15890ff [66/66] tty: fix data race between tty_init_dev and flush of buf
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
> reproduce:
>         git checkout fd7ea3a98728a4861c23d2c616649238f15890ff
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from init/do_mounts.c:15:0:
> >> include/linux/tty.h:437:1: error: expected identifier or '(' before '{' token
>     { return 0; }
>     ^
>    include/linux/tty.h:439:1: error: expected identifier or '(' before '{' token
>     { }
>     ^
>    In file included from init/do_mounts.c:15:0:
>    include/linux/tty.h:436:19: warning: 'tty_ldisc_lock' declared 'static' but never defined [-Wunused-function]
>     static inline int tty_ldisc_lock(struct tty_struct *tty, unsigned long timeout);
>                       ^~~~~~~~~~~~~~
>    include/linux/tty.h:438:20: warning: 'tty_ldisc_unlock' declared 'static' but never defined [-Wunused-function]
>     static inline void tty_ldisc_unlock(struct tty_struct *tty);
>                        ^~~~~~~~~~~~~~~~
> 
> vim +437 include/linux/tty.h
> 
>    393	
>    394	#ifdef CONFIG_TTY
>    395	extern void tty_kref_put(struct tty_struct *tty);
>    396	extern struct pid *tty_get_pgrp(struct tty_struct *tty);
>    397	extern void tty_vhangup_self(void);
>    398	extern void disassociate_ctty(int priv);
>    399	extern dev_t tty_devnum(struct tty_struct *tty);
>    400	extern void proc_clear_tty(struct task_struct *p);
>    401	extern struct tty_struct *get_current_tty(void);
>    402	/* tty_io.c */
>    403	extern int __init tty_init(void);
>    404	extern const char *tty_name(const struct tty_struct *tty);
>    405	extern struct tty_struct *tty_kopen(dev_t device);
>    406	extern void tty_kclose(struct tty_struct *tty);
>    407	extern int tty_dev_name_to_number(const char *name, dev_t *number);
>    408	extern int tty_ldisc_lock(struct tty_struct *tty, unsigned long timeout);
>    409	extern void tty_ldisc_unlock(struct tty_struct *tty);
>    410	#else
>    411	static inline void tty_kref_put(struct tty_struct *tty)
>    412	{ }
>    413	static inline struct pid *tty_get_pgrp(struct tty_struct *tty)
>    414	{ return NULL; }
>    415	static inline void tty_vhangup_self(void)
>    416	{ }
>    417	static inline void disassociate_ctty(int priv)
>    418	{ }
>    419	static inline dev_t tty_devnum(struct tty_struct *tty)
>    420	{ return 0; }
>    421	static inline void proc_clear_tty(struct task_struct *p)
>    422	{ }
>    423	static inline struct tty_struct *get_current_tty(void)
>    424	{ return NULL; }
>    425	/* tty_io.c */
>    426	static inline int __init tty_init(void)
>    427	{ return 0; }
>    428	static inline const char *tty_name(const struct tty_struct *tty)
>    429	{ return "(none)"; }
>    430	static inline struct tty_struct *tty_kopen(dev_t device)
>    431	{ return ERR_PTR(-ENODEV); }
>    432	static inline void tty_kclose(struct tty_struct *tty)
>    433	{ }
>    434	static inline int tty_dev_name_to_number(const char *name, dev_t *number)
>    435	{ return -ENOTSUPP; }
>    436	static inline int tty_ldisc_lock(struct tty_struct *tty, unsigned long timeout);
>  > 437	{ return 0; }

Ah, stupid typo, I'll go fix this up and push out the tree again...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux