On 13/01/18 11:59, Nuno Gonçalves wrote: > Dear Ed, > > Thanks. > > Tested-by: Nuno Goncalves <nunojpg@xxxxxxxxx> > > I just would like to report a aditional issue I find, which I am not > sure if it is intend behaviour or not. If I set bauds 1152000, > 1500000, 2000000, 2500000, 3000000, I always get a actually set baud > of 1500000, because it appears to be the closest baud by my hardware, > but if I set 3500000, then the port gets disabled. > > This is because up to 3000000 the closest integer divider is 1, but > then it becomes 0, which is invalid. > > If we still should return the closest baud, then we must return a > minimum of 1, and never 0, at uart_get_divisor, or > serial8250_get_divisor. > > Thanks, > Nuno Yes, returning a divisor of zero doesn't sound very sensible. Care to submit a patch? -- Ed -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
