Re: [PATCH v5 6/7] serial: imx: Use common rs485 device tree parsing function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 19, 2017 at 11:08:50AM +0200, Uwe Kleine-König wrote:
> On Tue, Sep 19, 2017 at 09:21:23AM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Sep 13, 2017 at 08:55:41PM +0200, Uwe Kleine-König wrote:
> > > On Wed, Sep 13, 2017 at 10:18:32AM +0200, Uwe Kleine-König wrote:
> > > > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > > 
> > > > This adds support for the rs485 specific properties defined in
> > > > Documentation/devicetree/bindings/serial/rs485.txt.
> > > > 
> > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > > ---
> > > >  drivers/tty/serial/imx.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > > > index fe368a46f8fe..7ff20bfcb12c 100644
> > > > --- a/drivers/tty/serial/imx.c
> > > > +++ b/drivers/tty/serial/imx.c
> > > > @@ -2051,6 +2051,8 @@ static int serial_imx_probe_dt(struct imx_port *sport,
> > > >  	if (of_get_property(np, "rts-gpios", NULL))
> > > >  		sport->have_rtsgpio = 1;
> > > >  
> > > > +	of_get_rs485_mode(np, &sport->port.rs485);
> > > > +
> > > 
> > > This patch is wrong. I don't know the details yet, but please don't
> > > apply this. I'll follow up when I completely understood the situation.
> > > 
> > > The other patches in this series are fine.
> > 
> > Ok, I've applied the previous 5 patches, and not the last 2.
> 
> Thanks
> 
> IMHO you can take patch 7, too. That's just a dt binding update and even
> if the imx driver doesn't implement it yet, that's for sure the way to
> go and documenting it already now doesn't hurt.
> 
> If you already recycled the mails, it doesn't matter much though, I
> will keep it in my stack on rebase then.

It's gone from my queue, please resend with the next set you send.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux