Re: [PATCH 2/2] serial: 8250: Use hrtimers for rs485 delays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafael,

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v4.13-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rafael-Gago/serial-core-Consider-rs485-settings-to-drive-RTS/20170719-144259
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Rafael-Gago/serial-core-Consider-rs485-settings-to-drive-RTS/20170719-144259 HEAD 40d465414b82473048e4b5d96ffee12933009bc0 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_port.c: In function 'serial8250_em485_init':
>> drivers/tty/serial/8250/8250_port.c:615:8: error: expected ')' before 'HRTIMER_MODE_REL'
           HRTIMER_MODE_REL);
           ^~~~~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_port.c:614:2: error: too few arguments to function 'hrtimer_init'
     hrtimer_init(&p->em485->start_tx_timer, CLOCK_MONOTONIC
     ^~~~~~~~~~~~
   In file included from include/linux/sched.h:19:0,
                    from include/linux/ratelimit.h:5,
                    from include/linux/device.h:27,
                    from include/linux/platform_device.h:14,
                    from drivers/tty/serial/8250/8250_port.c:29:
   include/linux/hrtimer.h:345:13: note: declared here
    extern void hrtimer_init(struct hrtimer *timer, clockid_t which_clock,
                ^~~~~~~~~~~~

vim +615 drivers/tty/serial/8250/8250_port.c

   582	
   583	/**
   584	 *	serial8250_em485_init() - put uart_8250_port into rs485 emulating
   585	 *	@p:	uart_8250_port port instance
   586	 *
   587	 *	The function is used to start rs485 software emulating on the
   588	 *	&struct uart_8250_port* @p. Namely, RTS is switched before/after
   589	 *	transmission. The function is idempotent, so it is safe to call it
   590	 *	multiple times.
   591	 *
   592	 *	The caller MUST enable interrupt on empty shift register before
   593	 *	calling serial8250_em485_init(). This interrupt is not a part of
   594	 *	8250 standard, but implementation defined.
   595	 *
   596	 *	The function is supposed to be called from .rs485_config callback
   597	 *	or from any other callback protected with p->port.lock spinlock.
   598	 *
   599	 *	See also serial8250_em485_destroy()
   600	 *
   601	 *	Return 0 - success, -errno - otherwise
   602	 */
   603	int serial8250_em485_init(struct uart_8250_port *p)
   604	{
   605		if (p->em485)
   606			return 0;
   607	
   608		p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_ATOMIC);
   609		if (!p->em485)
   610			return -ENOMEM;
   611	
   612		hrtimer_init(&p->em485->stop_tx_timer, CLOCK_MONOTONIC,
   613			     HRTIMER_MODE_REL);
 > 614		hrtimer_init(&p->em485->start_tx_timer, CLOCK_MONOTONIC
 > 615			     HRTIMER_MODE_REL);
   616		p->em485->stop_tx_timer.function = &serial8250_em485_handle_stop_tx;
   617		p->em485->start_tx_timer.function = &serial8250_em485_handle_start_tx;
   618		p->em485->port = p;
   619		p->em485->active_timer = NULL;
   620		serial8250_em485_rts_after_send(p);
   621	
   622		return 0;
   623	}
   624	EXPORT_SYMBOL_GPL(serial8250_em485_init);
   625	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux