On 2017-05-22 18:24, Jan Kiszka wrote: > On 2017-05-22 17:17, Technical Support wrote: >> Hello, >> >> The Exar MPIO pins are used by our device driver to control features of >> the line driver and can't be used as GPIO pins. I agree, the condition >> can be moved to 8250_exar prior to a platform device being created for >> the gpio_exar driver. >> > > Thanks a lot for the feedback! I will send a refactoring patch. Hmm, are you possibly talking about PCI device with the IDs 0x2, 0x4, 0xa, 0xb (4222PCI335, 4224PCI335, 2324PCI335, 2328PCI335), because those actually set the GPIOs for apparent internal reasons. However, 0x20..0x22 (4222PCIE, 4224PCIE, 4228PCIE) already share setup_gpio() via pci_xr17v35x_setup(), and that looks different. I'm also asking again because we just changed the default MPIO settings for the latter to all inputs. If you depended on them to be all outputs and 0, we may have broken something. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
