On Sat, May 13, 2017 at 10:29 AM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote: > Do not allocate resources on behalf of the parent device but on our own. > Otherwise, cleanup does not properly work if gpio-exar is removed but > not the parent device. This sounds to me like a good catch. FWIW: Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> > --- > drivers/gpio/gpio-exar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c > index 0a2085faf271..9138ee087c5d 100644 > --- a/drivers/gpio/gpio-exar.c > +++ b/drivers/gpio/gpio-exar.c > @@ -139,7 +139,7 @@ static int gpio_exar_probe(struct platform_device *pdev) > if (!p) > return -ENOMEM; > > - exar_gpio = devm_kzalloc(&pcidev->dev, sizeof(*exar_gpio), GFP_KERNEL); > + exar_gpio = devm_kzalloc(&pdev->dev, sizeof(*exar_gpio), GFP_KERNEL); > if (!exar_gpio) > return -ENOMEM; > > @@ -160,7 +160,7 @@ static int gpio_exar_probe(struct platform_device *pdev) > exar_gpio->regs = p; > exar_gpio->index = index; > > - ret = devm_gpiochip_add_data(&pcidev->dev, > + ret = devm_gpiochip_add_data(&pdev->dev, > &exar_gpio->gpio_chip, exar_gpio); > if (ret) > goto err_destroy; > -- > 2.12.0 > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
