On 04/16/2017 10:06 PM, Heiner Kallweit wrote: > The stop bit value as to be or'ed, so far this worked only just by chance > because AML_UART_STOP_BIN_1SB is 0. > > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > --- > drivers/tty/serial/meson_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 60f16795..e2e25da1 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -355,7 +355,7 @@ static void meson_uart_set_termios(struct uart_port *port, > if (cflags & CSTOPB) > val |= AML_UART_STOP_BIN_2SB; > else > - val &= ~AML_UART_STOP_BIN_1SB; > + val |= AML_UART_STOP_BIN_1SB; > > if (cflags & CRTSCTS) > val &= ~AML_UART_TWO_WIRE_EN; > Hi, in fact you can totally drop the else statement since it's a no-op in both cases. Neil -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
