On (03/26/17 22:47), Samuel Thibault wrote: > commit bbeddf52adc1 ("printk: move braille console support into > separate braille.[ch] files") introduced _braille_console_setup() > to outline the braille initialization code. There was however some > confusion over the value it was supposed to return. commit 2cfe6c4ac7ee > ("printk: Fix return of braille_register_console()") tried to fix it > but failed to. > > This fixes and documents the returned value according to the use > in printk.c: non-zero return means a parsing error, and thus this > console configuration should be ignored. I just found this patch in my gmail "spam" folder. sorry. the patch looks OK to me. btw, is there any reason why _braille_console_setup() and _braille_register_console()/_braille_unregister_console() names start with a dash? do we also want to "clean this up"? well since we are at it. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html