On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R <vigneshr@xxxxxx> wrote: > On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: >> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R <vigneshr@xxxxxx> wrote: >>> Passing "serial" as name during request_irq() results in all serial port >>> irqs have same name. This does not help much to easily identify which >>> irq belongs to which serial port instance. Therefore pass dev_name() >>> during request_irq() so that better identifiable name is listed for >>> serial ports in cat /proc/interrupts output. >>> >>> Output of cat /proc/interrupts >>> Before this patch: >>> 26: 689 0 GICv2 309 Edge serial >>> After this patch: >>> 26: 696 0 GICv2 309 Edge 2530c00.serial > But, this change is making interrupt name more descriptive It doesn't in PCI case, it makes it worse. (The world is not DT-centric) >> Besides that imagine what would be the name of PCI device here. >> I would suggest adding ID if you need one in a form like >> "serial%d", where ID may or may not be supplied by the actual 8250 drivers. >> > > Are you suggesting to use serial_index() as ID? Yes. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
