On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R <vigneshr@xxxxxx> wrote: > Passing "serial" as name during request_irq() results in all serial port > irqs have same name. This does not help much to easily identify which > irq belongs to which serial port instance. Therefore pass dev_name() > during request_irq() so that better identifiable name is listed for > serial ports in cat /proc/interrupts output. > > Output of cat /proc/interrupts > Before this patch: > 26: 689 0 GICv2 309 Edge serial > After this patch: > 26: 696 0 GICv2 309 Edge 2530c00.serial I don't know if it worth to mention that some (testing) tools may depend on this name. Besides that imagine what would be the name of PCI device here. I would suggest adding ID if you need one in a form like "serial%d", where ID may or may not be supplied by the actual 8250 drivers. > > Signed-off-by: Vignesh R <vigneshr@xxxxxx> > --- > drivers/tty/serial/8250/8250_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index 76e03a7de9cc..f83b69f30987 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -218,7 +218,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up) > spin_unlock_irq(&i->lock); > irq_flags |= up->port.irqflags; > ret = request_irq(up->port.irq, serial8250_interrupt, > - irq_flags, "serial", i); > + irq_flags, dev_name(up->port.dev), i); > if (ret < 0) > serial_do_unlink(i, up); > } > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
