On 2017-01-05 06:25, Christoph Hellwig wrote: > On Wed, Jan 04, 2017 at 11:46:58PM +0100, Jan Kiszka wrote: >>> I NAKed already third patch related to PCI managed resources (couple >>> of those regarding to pci_irq_* API)/ >>> >> >> Ah, there are resources that are managed without being allocated >> explicitly that way. Hmm, not very intuitive. Are MSI / MSI-X vectors >> the only such cases? > > MSI/MSI-X resources are not managed that way and an explicit call to > pci_free_irq_vectors is required from the API standpoint. It might not > actually free memory in many cases, but it still is a symmetric API. > Andy is referring to the following: - pcim_enable_device registers pci_devres with the devres subsystem - on device release, devres_release_all is invoked, and that calls pcim_release - the latter will invoke pci_disable_msi and pci_disable_msix if any of them is enabled The user will still call the same pci_msi_enable, pci_alloc_irq_vectors etc., but they are now "magically" managed with pcim_enable_device being used. Same for pci_request_region. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
