On Thu, Nov 10, 2016 at 05:25:41PM +0000, Ed Blake wrote: > On 11/10/16 15:49, Greg KH wrote: > > > If I do that it will still leave a single unsigned short 'bugs' and > > > single bool 'fifo_bug'. Should I move all of 'capabilities', 'bugs' > > > and 'fifo_bug' to the end of the structure, leaving everything before > > > it aligned? > > You can fix that all up in a follow-on patch after this one. The tool, > > pahole, should help out with ensuring that you got it correct. > > > > Compiled for x86_64, pahole showed a 1 byte hole after 'fifo_bug' and 4 byte > hole after 'msr_saved_flags', but however I move things around there is > always a total of 5 bytes of padding. 'pahole -- reorganize' also didn't > come up with anything better, so I propose to leave the order as it is. Ok, fair enough, thanks for trying. But it still should be u32, and not "unsigned int" :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
