[hint, don't use html email and your message will not be rejected by
vger.kernel.org]
On Thu, Nov 10, 2016 at 02:29:12PM +0000, Ed Blake wrote:
> On 11/10/16 13:47, Greg KH wrote:
>
> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h
> index 48ec765..4676968 100644
> --- a/include/linux/serial_8250.h
> +++ b/include/linux/serial_8250.h
> @@ -94,7 +94,7 @@ struct uart_8250_port {
> struct uart_port port;
> struct timer_list timer; /* "no irq" timer */
> struct list_head list; /* ports on this IRQ */
> - unsigned short capabilities; /* port capabilities */
> + unsigned int capabilities; /* port capabilities */
> unsigned short bugs; /* port bugs */
> It doesn't matter that much, but now you have some extra "padding" in
> here, can you move this somewhere that makes more sense and keep things
> aligned?
>
>
> Thanks for the review.
>
> Do you mean move 'capabilities' to somewhere else within the same structure?
Yes.
> If I do that it will still leave a single unsigned short 'bugs' and
> single bool 'fifo_bug'. Should I move all of 'capabilities', 'bugs'
> and 'fifo_bug' to the end of the structure, leaving everything before
> it aligned?
You can fix that all up in a follow-on patch after this one. The tool,
pahole, should help out with ensuring that you got it correct.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
