Re: [PATCH] vt: Make a comparison <= for readability.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 14, 2016 at 05:02:38PM +0200, Adam Borowski wrote:
> All other uses of vc_npar are inclusive (save for < NPAR) which raises
> eyebrows, so let's at least do so consistently.
> 
> Signed-off-by: Adam Borowski <kilobyte@xxxxxxxxxx>
> ---
>  drivers/tty/vt/vt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 42be354..e841a4e 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -1312,7 +1312,7 @@ static int vc_t416_color(struct vc_data *vc, int i,
>  	if (i > vc->vc_npar)
>  		return i;
>  
> -	if (vc->vc_par[i] == 5 && i < vc->vc_npar) {
> +	if (vc->vc_par[i] == 5 && i + 1 <= vc->vc_npar) {
>  		/* 256 colours */
>  		i++;
>  		rgb_from_256(vc->vc_par[i], &c);

Is this on top of your series here?  Or in replacement of patch 1/4?

Can you resend this series so I don't have to guess?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux