On Tue, Aug 02, 2016 at 11:06:54AM +0200, Helmut Grohne wrote:
> commit 6e14f7c1f2c2 ("tty: xuartps: Improve startup function") changed
> cdns_uart_startup to disable the transmitter. It turns out the disabling
> the transmitter may not be the best idea, because it tends to corrupt
> serial output and may cause hangs. commit e3538c37ee38 ("tty: xuartps:
> Beautify read-modify writes") accidentally changed
> cdns_uart_console_write from temporarily enabling the transmitter to
> permanently enabling it and thus improved the situation.
>
> Revert the disabling of the transmitter in cdns_uart_startup to have the
> transmitter always active.
>
> Clean up cdns_uart_console_write by removing the now unneeded write to
> the crontol register that formerly disabled the transmitter.
>
> Signed-off-by: Helmut Grohne <h.grohne@xxxxxxxxxx>
> Link: https://lkml.kernel.org/r/20160729073858.GA1416@laureti-dev
> Fixes: 6e14f7c1f2c2 ("tty: xuartps: Improve startup function")
> Fixes: e3538c37ee38 ("tty: xuartps: Beautify read-modify writes")
> ---
> drivers/tty/serial/xilinx_uartps.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
I can't figure out the order in which to apply your patches for this
driver, can you resend them all as a series so I know they will work
together properly?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
