On Fri, 2016-07-29 at 09:59:14 +0200, Helmut Grohne wrote:
> The bit mask changes in commit 6e14f7c1f2c2 ("tty: xuartps: Improve
> startup function") don't do what the commit message advertises. The
> original behaviour was clearing the RX_DIS bit, but due to missing ~,
> that bit is now the only bit kept.
>
> Currently, the regression is harmless, because the previous write to the
> control register sets it to TXRST | RXRST. Thus the RX_DIS bit is
> previously cleared. The *RST bits are cleared by the hardware, so this
> commit does not currently change behaviour, but makes future changes
> less risky.
>
> Signed-off-by: Helmut Grohne <h.grohne@xxxxxxxxxx>
> Fixes: 6e14f7c1f2c2 ("tty: xuartps: Improve startup function")
Reviewed-by: Sören Brinkmann <soren.brinkmann@xxxxxxxxxx>
Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
