Re: [PATCH v2] serial: 8250_fintek: Fix namespace collision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This has been already fixed by Arnd Bergmann

https://lkml.org/lkml/2016/6/27/163



On Mon, Jul 4, 2016 at 3:14 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> When building ARM allmodconfig the following warning is seen:
>
> drivers/tty/serial/8250/8250_fintek.c:34:0: warning: "IRQ_MODE" redefined
>  #define IRQ_MODE 0x70
>
> In file included from arch/arm/include/asm/ptrace.h:13:0,
>                  from arch/arm/include/asm/irqflags.h:6,
>                  from include/linux/irqflags.h:15,
>                  from arch/arm/include/asm/bitops.h:27,
>                  from include/linux/bitops.h:36,
>                  from include/linux/kernel.h:10,
>                  from include/linux/list.h:8,
>                  from include/linux/module.h:9,
>                  from drivers/tty/serial/8250/8250_fintek.c:11:
> arch/arm/include/uapi/asm/ptrace.h:55:0: note: this is the location of the previous definition
>  #define IRQ_MODE 0x00000012
>
> Fix the name collision by renaming 'IRQ_MODE' to 'IRQ_MODE_FINTEK'.
>
> Reported-by: Olof's autobuilder <build@xxxxxxxxx>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
> Changes since v1:
> - Add Reported-by tag
>
>  drivers/tty/serial/8250/8250_fintek.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index 737b4b3..0f0954d 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -31,7 +31,7 @@
>  #define IO_ADDR2 0x60
>  #define LDN 0x7
>
> -#define IRQ_MODE       0x70
> +#define IRQ_MODE_FINTEK        0x70
>  #define IRQ_SHARE      BIT(4)
>  #define IRQ_MODE_MASK  (BIT(6) | BIT(5))
>  #define IRQ_LEVEL_LOW  0
> @@ -195,7 +195,7 @@ static int fintek_8250_set_irq_mode(struct fintek_8250 *pdata, bool level_mode)
>         outb(LDN, pdata->base_port + ADDR_PORT);
>         outb(pdata->index, pdata->base_port + DATA_PORT);
>
> -       outb(IRQ_MODE, pdata->base_port + ADDR_PORT);
> +       outb(IRQ_MODE_FINTEK, pdata->base_port + ADDR_PORT);
>         tmp = inb(pdata->base_port + DATA_PORT);
>
>         tmp &= ~IRQ_MODE_MASK;
> --
> 1.9.1
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux