Hi Ricardo & Greg,
Ricardo Ribalda Delgado 於 2016/6/27 下午 06:25 寫道:
Hi Peter,. Hi Greg
On Fri, May 27, 2016 at 4:02 AM, Ji-Ze Hong (Peter Hong)
+ struct irq_data *irq_data = irq_get_irq_data(uart->port.irq);
+ bool level_mode = irqd_is_level_type(irq_data);
I see a potential problem with this patch:
If irq_get_irq_data fails, it will return NULL, resulting on a
segmentation fault on irqd_is_level_type:
#define __irqd_to_state(d) ACCESS_PRIVATE((d)->common, state_use_accessors)
I believe that we need to add error checks here
I'll try to send a patch to add more checks.
- return 0;
+ return fintek_8250_set_irq_mode(pdata, level_mode);
Also why do not call irq_get_irq_data() and irqd_is_level_type()
before return? There is no need to do that work if the probe
determines that it is not a fintek chip.
Also determine the IRQ mode when found a fintek chip.
Thanks to point out the potential issue.
--
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
