Re: [PATCH] serial: mxser.c - Cleanup opmode shiftbit calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sorry, I forgot to add version info.

This patch is against the latest stable -  4.6.2

Michal Kadlic

On 15. 6. 2016 14:24, Michal Kadlic wrote:
> Replace opmode shiftbit calculations with stored value per port (mxser_port.opmode_shift) .  Preload value in mxser_probe routine.
>
> Signed-off-by: Michal Kadlic <michal.kadlic@xxxxxxxxx>
>
> ---
>
> Mxser driver uses a packed opmode register ( 2bits per port) to switch between RS232,RS485 and RS422 mode. Shiftbit variable is calculated in several places to determine correct bits per port.
>
> Reasons for change:
>
> 1. Code cleanup - remove calculations scattered in code
> 2. ARCH_MOXART could use mxser.c in the future but it uses different bit offsets, so each calculation would need an #ifdef.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux