Re: [PATCH 4.7-rc1 1/1] 8250_pci: Adds support for the WCH CH355 4S card (corrected)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I have read Documentation/email-clients.txt and configure thunderbird appropriate
Also I have sent test letter to myself, and checked tabs.
Also I have removed kernel version from [ ] in the subject.
New post is located here:
http://marc.info/?l=linux-serial&m=146398710019191&w=2

On 05/18/2016 10:13 AM, Greg KH wrote:
> On Wed, May 18, 2016 at 10:20:53AM +0400, Alexandr Petrenko wrote:
>> Adds support for the WCH CH355 4S card in the 8250 serial driver.
>>
>> Signed-off-by: Alexandr Petrenko <petrenkoas83@xxxxxxxxx>
> 
> Better.  But why are you putting the kernel version in the [ ] in the
> subject?  We know you can't go back in time and apply it to an older
> kernel.
> 
> Look at the archives for how people do this.
> 
>> ---
>> --- drivers/tty/serial/8250/8250_pci.c.orig    2016-05-17
>> 15:39:19.504426878 +0300
> 
> Line wrapped :(
> 
>> +++ drivers/tty/serial/8250/8250_pci.c    2016-05-18 08:34:32.025194466 +0300
>> @@ -1850,6 +1850,16 @@ pci_wch_ch353_setup(struct serial_privat
>>  }
>>
>>  static int
>> +pci_wch_ch355_setup(struct serial_private *priv,
>> +        const struct pciserial_board *board,
>> +        struct uart_8250_port *port, int idx)
>> +{
>> +    port->port.flags |= UPF_FIXED_TYPE;
>> +    port->port.type = PORT_16550A;
>> +    return pci_default_setup(priv, board, port, idx);
>> +}
> 
> tabs are turned to spaces :(
> 
> Please spend the time and send the patch to yourself to figure out how
> to get this working correctly.
> 
> thanks,
> 
> greg k-h
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux