Jean Delvare <jdelvare@xxxxxxx> writes: > Hi Måns, > > On Sun, 06 Mar 2016 10:46:00 +0000, Måns Rullgård wrote: >> Jean Delvare <jdelvare@xxxxxxx> writes: >> >> > Kconfig option SERIAL_8250_RT288X seems to be only relevant on MIPS >> > platforms, so do not present it on other architectures, unless >> > build-testing. >> > >> > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> >> > Cc: John Crispin <blogic@xxxxxxxxxxx> >> > Cc: Mans Rullgard <mans@xxxxxxxxx> >> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> > Cc: Jiri Slaby <jslaby@xxxxxxxx> >> > --- >> > drivers/tty/serial/8250/Kconfig | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > --- linux-4.5-rc5.orig/drivers/tty/serial/8250/Kconfig 2016-02-02 09:02:09.024931552 +0100 >> > +++ linux-4.5-rc5/drivers/tty/serial/8250/Kconfig 2016-02-21 14:41:04.446069293 +0100 >> > @@ -295,6 +295,7 @@ config SERIAL_8250_EM >> > config SERIAL_8250_RT288X >> > bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support" >> > depends on SERIAL_8250 >> > + depends on MIPS || COMPILE_TEST >> > default y if MIPS_ALCHEMY || SOC_RT288X || SOC_RT305X || SOC_RT3883 || SOC_MT7620 >> > help >> > Selecting this option will add support for the alternate register >> > >> >> NAK. >> >> This is required on Sigma Designs SMP87xx which is ARM based as well. > > Didn't know, thanks for the information. So we can change it to: > > depends on MIPS || ARCH_TANGO || COMPILE_TEST > > Would that work for you? If so I will send a v2 of the patch. > >> If you want to reduce Kconfig clutter, I don't see a problem with >> removing the option entirely. The code it enables is tiny. > > I know that's a small amount of code, and I love reducing the number of > options in Kconfig, however I don't think it is fair to enlarge > everyone's kernel for a few systems that can't stick to a standard. > That must be the reason why the option was added in the first place and > I am not questioning this decision. I hate dead code in my kernel even > more than Kconfig clutter ;-) What about the other bits that are only there to support some obscure 8250 variant? -- Måns Rullgård -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
