Re: [PATCH] serial: 8250: Add hardware dependency to RT288X option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jean Delvare <jdelvare@xxxxxxx> writes:

> Kconfig option SERIAL_8250_RT288X seems to be only relevant on MIPS
> platforms, so do not present it on other architectures, unless
> build-testing.
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: John Crispin <blogic@xxxxxxxxxxx>
> Cc: Mans Rullgard <mans@xxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxxx>
> ---
>  drivers/tty/serial/8250/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-4.5-rc5.orig/drivers/tty/serial/8250/Kconfig	2016-02-02 09:02:09.024931552 +0100
> +++ linux-4.5-rc5/drivers/tty/serial/8250/Kconfig	2016-02-21 14:41:04.446069293 +0100
> @@ -295,6 +295,7 @@ config SERIAL_8250_EM
>  config SERIAL_8250_RT288X
>  	bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
>  	depends on SERIAL_8250
> +	depends on MIPS || COMPILE_TEST
>  	default y if MIPS_ALCHEMY || SOC_RT288X || SOC_RT305X || SOC_RT3883 || SOC_MT7620
>  	help
>  	  Selecting this option will add support for the alternate register
>

NAK.

This is required on Sigma Designs SMP87xx which is ARM based as well.

If you want to reduce Kconfig clutter, I don't see a problem with
removing the option entirely.  The code it enables is tiny.

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux