2016-02-08 11:24 GMT+09:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Mon, Feb 08, 2016 at 02:06:14AM +0000, yamada.masahiro@xxxxxxxxxxxxx wrote: >> Greg, >> >> >> No, this patch should not be applied. >> >> >> As discussed in >> https://patchwork.kernel.org/patch/8028771/ >> the build error had already been fixed by the following commit: >> >> >> commit 71f50c6d9a2276f3ec85384bffe2aee1962f4669 >> Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> >> Date: Fri Jan 22 01:33:51 2016 +0900 >> >> of: drop symbols declared by _OF_DECLARE() from modules >> >> The users of this macro (OF_EARLYCON_DECLARE, CLK_OF_DECLARE, >> IRQCHIP_DECLARE, etc.) are only parsed in the early boot stage. >> Such symbols contained in modules are never used. >> >> This commit fixes the link error introduced by commit b8d20e06eaad >> ("serial: 8250_uniphier: add earlycon support"); the combination >> of CONFIG_SERIAL_8250_UNIPHIER=m and CONFIG_SERIAL_8250_CONSOLE=y >> fails to link: >> >> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefin >> >> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support") >> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> >> Acked-by: Arnd Bergmann <arnd@xxxxxxxx> >> Signed-off-by: Rob Herring <robh@xxxxxxxxxx> >> > > Oops. sorry about that, thanks for letting me know, I'll go revert it > now. Or, simply drop the noise commit? The commit was just applied yesterday and not so many patches on top of that. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
