RE: patch "8250: uniphier: allow modular build with 8250 console" added to tty-linus

[<yamada.masahiro@xxxxxxxxxxxxx>]

Greg,


No, this patch should not be applied.


As discussed in
https://patchwork.kernel.org/patch/8028771/
the build error had already been fixed by the following commit:


commit 71f50c6d9a2276f3ec85384bffe2aee1962f4669
Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Date:   Fri Jan 22 01:33:51 2016 +0900

    of: drop symbols declared by _OF_DECLARE() from modules
    
    The users of this macro (OF_EARLYCON_DECLARE, CLK_OF_DECLARE,
    IRQCHIP_DECLARE, etc.) are only parsed in the early boot stage.
    Such symbols contained in modules are never used.
    
    This commit fixes the link error introduced by commit b8d20e06eaad
    ("serial: 8250_uniphier: add earlycon support"); the combination
    of CONFIG_SERIAL_8250_UNIPHIER=m and CONFIG_SERIAL_8250_CONSOLE=y
    fails to link:
    
    ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefin
    
    Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
    Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
    Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
    Signed-off-by: Rob Herring <robh@xxxxxxxxxx>




> -----Original Message-----
> From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Sunday, February 07, 2016 4:05 PM
> To: arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; Yamada, Masahiro/山田 真
> 弘
> Subject: patch "8250: uniphier: allow modular build with 8250 console" added
> to tty-linus
> 
> 
> This is a note to let you know that I've just added the patch titled
> 
>     8250: uniphier: allow modular build with 8250 console
> 
> to my tty git tree which can be found at
>     git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> in the tty-linus branch.
> 
> The patch will show up in the next release of the linux-next tree (usually
> sometime within the next 24 hours during the week.)
> 
> The patch will hopefully also be merged in Linus's tree for the next -rc
> kernel release.
> 
> If you have any questions about this process, please let me know.
> 
> 
> From d56edd7ed0ed46a8043ee3040ededbd190818ccf Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@xxxxxxxx>
> Date: Wed, 13 Jan 2016 23:33:59 +0100
> Subject: 8250: uniphier: allow modular build with 8250 console
> 
> The recently added uniphier 8250 port driver supports early console probing,
> and it supports being built as a module, but the combination of the two
> fails to link:
> 
> ERROR: "early_serial8250_setup"
> [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
> 
> Given that earlycon support in a loadable module makes no sense, making
> that code conditional on 'MODULE' is a correct solution.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
> Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_uniphier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c
> b/drivers/tty/serial/8250/8250_uniphier.c
> index bab6b3ae2540..1b7bd26555b7 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>  	spinlock_t atomic_write_lock;
>  };
> 
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>  static int __init uniphier_early_console_setup(struct earlycon_device
> *device,
>  					       const char *options)
>  {
> --
> 2.7.0
> 

’抅ŗ{.nĒ+‰·Ÿ®‰­†+%ŠĖ’演欟„Šw’ŗ{.nĒ+‰轡Š{応寧‰©’Š{ayŗŹ‡Ś™ė,j②f▶·hšļź’‘裹z_莅(㊨šŽŠ蘗j"ś¶m§’’¾̚G«é’ヿ?™◑?&ｘ§~į