Re: [PATCH] serial: 8250: Mark Fintek driver as PNP incompatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 13, 2016 at 12:30 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Jan 12, 2016 at 11:53:49PM +0100, Ricardo Ribalda Delgado wrote:
>> Hi Greg
>>
>> On Tue, Jan 12, 2016 at 11:38 PM, Greg Kroah-Hartman
>> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> >> +     depends on SERIAL_8250 && PNP && !SERIAL_8250_PNP
>> >> +     default n
>> >
>> > This is only going to help at build time, not run time, which I thought
>> > you wanted to help resolve.  In other words, this isn't going to help
>> > 99% of the users out there as they use distro kernels that enable
>> > everything.
>> >
>> > Is that ok?
>>
>> The great advantage of the fintek driver against the standard pnp is
>> the rs485 functionality, which is something I don't expect to be used
>> by the distro users.
>
> Why not?  Are you saying that 99.9% of Linux users will never be able to
> use your driver?
>
>> This patch buys me some time until I figure out a good way for both
>> drivers to coexist.
>
> Let's just mark it as broken, as Peter originally did, if they can't
> coexist today, until that gets fixed.  That should give people more of a
> reason to work on it :)

What about removing the  .id_table from the struct pnp_driver of 8250_fintek?

By default it will load with the pnp driver.

The user can later bind/unbind the pnp driver in favor of the fintek
driver via sysfs if needed.

>
> thanks,
>
> greg k-h



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux