Re: [PATCH] serial: 8250: Mark Fintek driver as PNP incompatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 12, 2016 at 06:19:06PM +0100, Ricardo Ribalda Delgado wrote:
> From: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> 
> The 8250_fintek driver advertises as the PNP0501 driver; however this
> conflicts with the standard 16550A uart PNP0501. The conflict causes
> the 8250_fintek driver to load with _every_ PNP0501, but never probe,
> and causing the entire 8250 driver stack to unload if the 8250_fintek
> driver is unloaded (modprobe doesn't know that 8250_pnp rather than
> 8250_fintek claimed the resource).
> 
> Credit-to: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> Reported-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> ---
>  drivers/tty/serial/8250/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 6412f1455beb..3b6cfd3a3ac6 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -331,7 +331,8 @@ config SERIAL_8250_OMAP_TTYO_FIXUP
>  
>  config SERIAL_8250_FINTEK
>  	tristate "Support for Fintek F81216A LPC to 4 UART"
> -	depends on SERIAL_8250 && PNP
> +	depends on SERIAL_8250 && PNP && !SERIAL_8250_PNP
> +	default n

This is only going to help at build time, not run time, which I thought
you wanted to help resolve.  In other words, this isn't going to help
99% of the users out there as they use distro kernels that enable
everything.

Is that ok?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux