Re: [PATCH] serial: 8250: Mark Fintek driver as CONFIG_BROKEN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ricardo,

On 01/12/2016 12:44 AM, Ricardo Ribalda Delgado wrote:
> Hello Peter
> 
> On Tue, Jan 12, 2016 at 12:52 AM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
>> The 8250_fintek driver advertises as the PNP0501 driver; however this
>> conflicts with the standard 16550A uart PNP0501. The conflict causes
>> the 8250_fintek driver to load with _every_ PNP0501, but never probe,
>> and causing the entire 8250 driver stack to unload if the 8250_fintek
>> driver is unloaded (modprobe doesn't know that 8250_pnp rather than
>> 8250_fintek claimed the resource).
> 
> Sorry about that. I wrongly assumed that PNP to be unique to our platform :S.
> 
> As an initial workaround we could change the Kconfig to && !SERIAL_8250_PNP
> 
> depends on SERIAL_8250 && PNP && !SERIAL_8250_PNP
> 
> That way the driver can still be used with the proper kernel
> configuration (which is fine in an embedded environment)

Yeah, that would be fine.

> The second step could be to call the fintek probe from the
> 8250_pnp.... what dow you think about this?

If the probe can be read-only (or at least improve the confidence level that
the part is a fintek before i/o writes), then that would be ok.

My concern is that a distro will enable this fintek driver and millions
of machines that have standard 16550A ports (every desktop shipped in the
last 2 decades) will be unsafely probed.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux